Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create query_adjectives #121

Merged

Conversation

henrikth93
Copy link
Member

@henrikth93 henrikth93 commented Mar 24, 2024

A query for Japanese adjectives. They follow certain grammatical rules.

Contributor checklist


Description

Related issue

A query for Japanese adjectices. They follow certain grammatical rules.
Copy link

github-actions bot commented Mar 24, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Requested review rather than assigned :) I'll take a look at this soon, @henrikth93!

@henrikth93
Copy link
Member Author

Requested review rather than assigned :) I'll take a look at this soon, @henrikth93!

Yes, sorry about that

henrikth93 and others added 2 commits March 30, 2024 17:27
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting and added in a doc string to the file, @henrikth93 😊 Appreciate you putting all of this together! Super great that we have the first adjectives in!

@andrewtavis andrewtavis merged commit a1b182e into scribe-org:main Mar 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants