-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement pathlib into the update_data.py file #172
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
Ok, @Jk40git :) I've merged in the other PRs for the docs and removed the changes from this PR. There's still lots to do here though. I can help with this, but we're looking to replace all instances where there's a path with a |
Okay Thanks @andrewtavis I will review my suggestion path should be the src path or scribe-data path? |
Hey @Jk40git 👋 I'm in the midst of doing some fixes for this and will go ahead and take care of it myself. Thanks so much for the efforts in fixing this! Hope you're well :) |
All right. I am good, been busy those days that's why. |
Contributor checklist
--- Expand Scribe-Data paths to allow for Windows commands #125
Description
Implement pathlib for the paths to be accurately accessed . Don't know if the pathlib was well adopted. Sure there will be some changes to make
Related issue