Expand Hausa data queries for nouns, proper nouns, and verbs (Issue #116 Solved) #461
Conversation
- Enhanced noun query to include definite and indefinite forms - Updated proper noun query with definite and vocative forms - Expanded verb query to cover past simple, present continuous, future tense, and imperative forms - Added comments and FILTER options for both Latin and Arabic script variants - Improved overall query structure and readability
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
|
Would you be able to solve the merge conflicts here, @Collins-Webdev? :) |
Sure ! |
|
|
@andrewtavis , conflicts solved ! 😊 |
- Removed invalid grammatical features (Q1423695, Q618612) - Simplified past and present tense forms using validated QIDs - Maintained imperative forms (singular and plural) - Kept both Latin and Arabic script filter options
- Corrected form representation labels to match metadata - Removed invalid QIDs and replaced with supported ones - Fixed variable naming consistency between forms and representations - Updated tense forms to use valid grammatical feature QIDs - Simplified form labels to avoid validation errors
|
Hey @Collins-Webdev 👋 Let me handle the rest of this one :) There's a bug in the form check that I'd like to figure out, and this PR is an easy way to test it 😊 |
|
Hey @andrewtavis 👋, Got it! Thanks for taking care of it 😊. Let me know if you need any further help or testing on my end. |
There was a problem hiding this comment.
As far as the Hausa queries are concerned, @Collins-Webdev, there's no data being returned for many of the added forms. Let's only add forms in if there is data, as without that we won't exactly no know the Wikidata editors will model the information.
Thanks for this!
|
Thanks for merging the PR and helping with the conflict @andrewtavis 🙏🏽. |
Contributor checklist
pytestcommand as directed in the testing section of the contributing guideDescription
Related issue