Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve numpydoc docstring warnings #547 #552

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

MdSayemkhan
Copy link
Contributor

@MdSayemkhan MdSayemkhan commented Jan 19, 2025

  • Convert function summaries to infinitive verb form
  • Fix parameter and return value descriptions
  • Make docstrings more concise and accurate

Fixes #547

Contributor checklist


Description

Related issue

- Convert function summaries to infinitive verb form
- Fix parameter and return value descriptions
- Make docstrings more concise and accurate

Fixes scribe-org#547
Copy link

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo (can be set with git config --global user.email "GITHUB_EMAIL")

@andrewtavis andrewtavis self-requested a review January 19, 2025 14:27
@andrewtavis
Copy link
Member

Amazing to get some help here, @MdSayemkhan! I'll try to check this later 😊

@@ -207,13 +202,10 @@ def convert_to_csv_or_tsv(
----------
language : str
The language of the file to convert.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep these spaces so the docstrings aren't as dense :) For me makes it easier to read them 😊

- id: numpydoc-validation
files: ^src/
exclude: ^tests/
# - repo: https://github.com/numpy/numpydoc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's comment this out for now so we're not blocking others, and we can turn it back on as we work on this?

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far some amazing progress here, @MdSayemkhan! I'll bring this in and then we can work on some of the other warnings? You'd be very welcome to continue on this if you'd have interest!

@andrewtavis andrewtavis merged commit 0989f03 into scribe-org:main Jan 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix all numpydoc docstring warnings
2 participants