Update lib.rs and added few more punctuation marks

[KesharwaniArpita]

Contributor checklist

• This pull request is on a separate branch and not the main branch

---

Description

This pull request enhances the allowed_keys function by adding support for a comprehensive set of punctuation marks and special characters. The function previously handled only a limited selection of punctuation, such as commas and semicolons. This update improves the coverage of punctuation, allowing the function to return characters like apostrophes, periods, exclamation marks, and more.

1. Enhances text and command input functionality by ensuring that all common punctuation marks are recognized and processed.
2. Ensures a more complete user experience when handling textual data, especially in cases requiring punctuation.

Related issue

• Missing punctutation #11

[github-actions]

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Desktop rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

• The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

  • The contributor's name and icon in remote commits should be the same as what appears in the PR
  • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Desktop repo

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[andrewtavis]

Hey @RyanPaulGannon, would you have a moment to do an initial review here? :)

[RyanPaulGannon]

Hey @KesharwaniArpita! Thanks for the PR, there's a few lines here that aren't compiling but it's because it's not part of the Key enum :)

If you take a look at this link, you'll be able to correct the lines and resubmit :)

If you need any help, give me a shout!

[RyanPaulGannon]

Please review comments and refer to the rdev crate please. There are still a few variants used that aren't included in the enum which is causing the program to not complie.

Please run:

cargo build
cargo run --bin scribe

before committing so you can check to see that the program works first :)

[RyanPaulGannon]

Thanks for updating, however there are still some errors causing the compilation error. Please run the commands I have listed in my previous comment and make the changes identified by cargo, if you need any help then please ask. Please don't push commits without checking the compilation works correctly :)

[KesharwaniArpita]

@RyanPaulGannon I am so sorry for the inconvenience. That surely wasn't the intention. It should work fine now.
Can you help me with one more thing? While trying to run

cargo build
cargo run --bin scribe

I keep on getting the following error and I can't figure out what is causing them. Is there anything missing in the contributing.md ? or anything that you think I might have missed?

[RyanPaulGannon]

Don't worry at all, the PR is looking great now - thank you!
Okay, so I guess I've assumed everyone contributing would have cargo installed - my bad. You'll have to follow these instructions to ensure you have Rust and cargo installed to your machine; it's the build tool for Rust :)

Thank you for highlighting this as we'll need to add it to the contributing.md :)

[RyanPaulGannon]

Looking good, I'm happy that this satisfies #11! Eventually, there will need more work doing regarding punctuation, however, it'll be done alongside implementing the Shift key to allow for capitalisation and general shifting of keys.

[andrewtavis]

Nice I'll check the docs to make sure the notes on Cargo are explicit (enough) :)

[RyanPaulGannon]

If you would like me to make the PR for it, I can do - just let me know, I know you're a busy man!

[andrewtavis]

Ya that actually would be really nice, @RyanPaulGannon :) Thank you!

[andrewtavis]

Thanks for the contribution, @KesharwaniArpita, and also for the review, @RyanPaulGannon! 🚀