-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accelerate wit_infer_by_expr via grid-strde-loop & vector pool #775
Draft
hero78119
wants to merge
18
commits into
scroll-tech:master
Choose a base branch
from
hero78119:feat/wit_infer_opt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hero78119
commented
Dec 19, 2024
hero78119
force-pushed
the
feat/wit_infer_opt
branch
from
December 19, 2024 12:03
646ebfc
to
899727c
Compare
hero78119
force-pushed
the
feat/wit_infer_opt
branch
from
December 19, 2024 12:15
899727c
to
d3a2f4b
Compare
hero78119
changed the title
accelerate wit_infer_by_expr via grid-strde-loop + vector pool
accelerate wit_infer_by_expr via grid-strde-loop & vector pool
Dec 19, 2024
It seems I am test on the wrong branch, will update it once benchmark result is confirmed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #772
This PR re-design
wit_infer_by_expr
to try grid-strde-loop traverse + reuse a simple vector pool to make vector reuse across closure of expression evaluation. This design is aiming to avoid massively interface change.highlight of change
wit_infer_by_expr
to usegrid-strde-loop
style and maximize cpu cache hit rate. vector are updated concurrently with SyncUnsafeCell, which require nightly feature#![feature(sync_unsafe_cell)]
.benchmark
with command
on ceno server (16 cores, 32 HT) fibonacci e2e latency reduce ~13%