-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More progress on completing the trace monad rule set #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corlewis
commented
Nov 14, 2023
lsf37
reviewed
Nov 14, 2023
lsf37
reviewed
Nov 14, 2023
lsf37
reviewed
Nov 14, 2023
lsf37
reviewed
Nov 14, 2023
lsf37
reviewed
Nov 14, 2023
lsf37
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad we're doing this. These rules would be so much pain to discover and add incrementally during the proofs, and it would lead to a complete mess.
corlewis
force-pushed
the
trace_more_rules
branch
from
January 31, 2024 23:33
a418bc3
to
2214c0e
Compare
corlewis
force-pushed
the
trace_more_rules
branch
from
February 20, 2024 23:07
2214c0e
to
6d01cc6
Compare
Signed-off-by: Corey Lewis <[email protected]>
Signed-off-by: Corey Lewis <[email protected]>
Signed-off-by: Corey Lewis <[email protected]>
Signed-off-by: Corey Lewis <[email protected]>
Signed-off-by: Corey Lewis <[email protected]>
corlewis
force-pushed
the
trace_more_rules
branch
from
February 20, 2024 23:25
6d01cc6
to
06fed73
Compare
This is a relatively trivial definition, but it makes rules easier to write and to instantiate. Signed-off-by: Corey Lewis <[email protected]>
This adds rules for trace monad specific functions Signed-off-by: Corey Lewis <[email protected]>
Signed-off-by: Corey Lewis <[email protected]>
Signed-off-by: Corey Lewis <[email protected]>
Signed-off-by: Corey Lewis <[email protected]>
Signed-off-by: Corey Lewis <[email protected]>
corlewis
force-pushed
the
trace_more_rules
branch
from
February 21, 2024 04:58
06fed73
to
08f264f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the rule sets for the various monad properties (
no_trace
,no_fail
, etc.) to cover all of the monad primitives that we have. It does not touch the RG rule set.