Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improvements to ccorres_While #697

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

michaelmcinerney
Copy link
Contributor

Please see the commit message.

@michaelmcinerney
Copy link
Contributor Author

I suppose I should update the commit message to refer not to "the setter" but rather to "cond", given the change I made to the rule (if people are happy with the cond naming)

Copy link
Member

@corlewis corlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and thanks for the comment!

Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like cond better than setter, and the comment is good. Should give is enough information to figure out what is going on when we encounter this the next time.

Copy link
Member

@Xaphiosis Xaphiosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up from me. It's a tricky rule, I think you've done a good job making it as understandable as possible.

This adds information about the return relation to the C guards
and the C preconditions of the assumptions.

The C hoare triples for cond have also been consolidated, to
help simplify applications where the C guards are minimal.

A comment about its intended use is given.

Signed-off-by: Michael McInerney <[email protected]>
@michaelmcinerney michaelmcinerney force-pushed the michaelm-new_ccorres_While branch from 9d37d77 to cddb1bf Compare December 6, 2023 00:55
@michaelmcinerney michaelmcinerney merged commit 0ba3f8e into master Dec 6, 2023
14 checks passed
@michaelmcinerney michaelmcinerney deleted the michaelm-new_ccorres_While branch December 6, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants