Improve algorithm for Dice Coefficient #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pad words at start and end to compensate for underweighting of characters at word edges. In FuzzyMatch::Similarity, remove fallback to Levenshtein for words < 3 characters long.
|
Paging @seamusabshere, any objections to merging this? |
|
It appears this gem has gone fallow/neglected, which is too bad because it's a great place to start with for its purpose. I am using this patch from @rlue in an app and it definitely improves my matching for strings with short tokens. |
|
hey @rlue @karpet , sorry for the abandonware. ASAP, i'll update this to use https://github.com/seamusabshere/pg_trgm internally - replacing dice's (aka bigram) and levenshtein, and proven to work like postgres |
gyfis
added a commit
to gyfis/fuzzy_match
that referenced
this pull request
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pad words at start and end to compensate for underweighting of characters
at word edges. In FuzzyMatch::Similarity, remove fallback to Levenshtein
for words < 3 characters long.
(Fix for issue #22.)