Skip to content

Commit

Permalink
Merge pull request kubernetes#59587 from cblecker/cblecker-vendor
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add cblecker to vendor OWNERS

**What this PR does / why we need it**:
Adds myself to vendor OWNERS. I can help approve dep bumps of existing deps, and refer to Tim and new deps for license review.

**Release note**:
```release-note
NONE
```

/assign thockin
  • Loading branch information
Kubernetes Submit Queue authored Feb 20, 2018
2 parents 96ec318 + 6fb2304 commit 852e7f7
Show file tree
Hide file tree
Showing 15 changed files with 63 additions and 4 deletions.
4 changes: 4 additions & 0 deletions Godeps/OWNERS

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions OWNERS_ALIASES
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,9 @@ aliases:
- piosz
- jsafrane
- jbeda
vendor-reviewers:
dep-reviewers:
- cblecker
- thockin
vendor-approvers:
dep-approvers:
- cblecker
- thockin
11 changes: 10 additions & 1 deletion hack/godep-save.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ set -o pipefail

KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
source "${KUBE_ROOT}/hack/lib/init.sh"
source "${KUBE_ROOT}/hack/lib/util.sh"

kube::log::status "Ensuring prereqs"
kube::util::ensure_single_dir_gopath
Expand Down Expand Up @@ -86,5 +85,15 @@ hack/update-bazel.sh >/dev/null
kube::log::status "Updating LICENSES file"
hack/update-godep-licenses.sh >/dev/null

kube::log::status "Creating OWNERS file"
rm -f "Godeps/OWNERS" "vendor/OWNERS"
cat <<__EOF__ > "Godeps/OWNERS"
reviewers:
- dep-reviewers
approvers:
- dep-approvers
__EOF__
cp "Godeps/OWNERS" "vendor/OWNERS"

# Clean up
rm -rf "${BACKUP}"
2 changes: 1 addition & 1 deletion hack/verify-godeps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ pushd "${KUBE_ROOT}" 2>&1 > /dev/null
ret=1
fi

if ! _out="$(diff -Naupr -x "BUILD" -x "OWNERS" -x "AUTHORS*" -x "CONTRIBUTORS*" vendor ${_kubetmp}/vendor)"; then
if ! _out="$(diff -Naupr -x "BUILD" -x "AUTHORS*" -x "CONTRIBUTORS*" vendor ${_kubetmp}/vendor)"; then
echo "Your vendored results are different:" >&2
echo "${_out}" >&2
echo "Godeps Verify failed." >&2
Expand Down
4 changes: 4 additions & 0 deletions staging/src/k8s.io/api/Godeps/OWNERS

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions staging/src/k8s.io/apiextensions-apiserver/Godeps/OWNERS

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions staging/src/k8s.io/apimachinery/Godeps/OWNERS

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions staging/src/k8s.io/apiserver/Godeps/OWNERS

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions staging/src/k8s.io/client-go/Godeps/OWNERS

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions staging/src/k8s.io/code-generator/Godeps/OWNERS

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions staging/src/k8s.io/kube-aggregator/Godeps/OWNERS

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions staging/src/k8s.io/metrics/Godeps/OWNERS

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions staging/src/k8s.io/sample-apiserver/Godeps/OWNERS

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions staging/src/k8s.io/sample-controller/Godeps/OWNERS

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions vendor/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
reviewers:
- dep-reviewers
approvers:
- dep-approvers

0 comments on commit 852e7f7

Please sign in to comment.