Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Let shellcheck handle good vs bad shell types
This matches official shellcheck pre-commit hook at [1]. This works because shellcheck will silently skip "badShells" so there isn't a good reason to do this here. The old setup was actually causing pre-commit to skip shell scripts ending with .sh since both types *and* types_or were specified but the identified tags resulted in an empty set: $ cat t.sh echo hi $ nix-shell -p python3Packages.identify --run 'identify-cli t.sh' ["file", "non-executable", "shell", "text"] An argument could be had that 'sh' should have shown up due to the extension similar to other shells but I still believe we should merge this and match upstream. 1: https://github.com/koalaman/shellcheck-precommit/blob/v0.9.0/.pre-commit-hooks.yaml#L7
- Loading branch information