Update/actions version #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #585 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 14 14
Lines 3187 3187
Branches 433 433
=======================================
Hits 3177 3177
Misses 4 4
Partials 6 6 ☔ View full report in Codecov by Sentry. |
sepandhaghighi
requested changes
Jan 9, 2025
There was a problem hiding this comment.
@AHReccese Thanks for your effort 💯
Please take a look at my comment.
CHANGELOG.md
Outdated
| @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
| 4. KuhnsVI | |||
| 5. KuhnsVII | |||
| ### Changed | |||
| - versions of `checkout` and `setup-python` github action | |||
There was a problem hiding this comment.
Since checkout and setup-python aren't included in the main section of the library, I recommend replacing this line with - Test system modified.
sepandhaghighi
added
test
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
In this PR, I updated the version of the GitHub actions that were used.
What does this implement/fix? Explain your changes.
Any other comments?