Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log retention is not set when threre no aws resources in project #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fernandomoraes
Copy link

If the project contains none aws resources, the log retention is not set, this happens due to a bug in the implementation logic.

@fernandomoraes
Copy link
Author

#4

@szabolcsmaj
Copy link

Can @ArtificerEntertainment or @MichaelRBond merge this?

@MichaelRBond
Copy link
Contributor

I cannot.

@janfeshanmehran
Copy link

is there any update on this MR?

@szabolcsmaj
Copy link

After a lot of googling, I found the owner (at least I think it is) of the account @ArtificerEntertainment . I wrote an email to him but he didn't answer at all. He could at least give/share the ownership of the repo so that It can be improved without him.

@Jalle19
Copy link

Jalle19 commented Jan 8, 2021

I tried this plugin in order to replace having to define custom resources for each log group just to be able to change their retention time, only to find out it didn't work because I removed the whole resources section...

@ArtificerEntertainment please, merge this.

@janfeshanmehran
Copy link

I do appreciate it if, anyone can merge this PR

@joquijada
Copy link

After a lot of googling, I found the owner (at least I think it is) of the account @ArtificerEntertainment . I wrote an email to him but he didn't answer at all. He could at least give/share the ownership of the repo so that It can be improved without him.

It's a shame the owner is not actively monitoring this. I opened PR #8 but I guess there won't be any luck getting that merged in anytime soon. Anyone in favor of forking this project? @ArtificerEntertainment or @MichaelRBond

@MichaelRBond
Copy link
Contributor

I don't have permissions to perform the merge. Sorry :-(

We do use this plugin in a number of projects, and I'd like to see it maintained as well.

Are there a couple people that would like to be owners / maintainers? If we can find a couple people it might be easier to sustain over time with a fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants