#cnsqa-1672 add new AfterResponseSend event #599
Conversation
🦋 Changeset detectedLatest commit: e8f0dc5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -205,6 +206,7 @@ module.exports = function serverAppFactory({ | |||
|
|
|||
| res.status(context.response.status); | |||
| res.send(context.response.content); | |||
| await emitter.emitParallel(Event.AfterResponseSend, event); | |||
There was a problem hiding this comment.
We need a try catch block here and we can use logger.error to print some info (see
There was a problem hiding this comment.
Also, about the discussions earlier today, this code should not be reached twice in any scenario, because of the res.headersSent check above, so we do not need to do any additional handling here.
There was a problem hiding this comment.
try-catch block with logger.error added
There was a problem hiding this comment.
you used a little bit different log structure compared to the one i linked above (logger.error('...', { error }) vs. logger.error('...', error)), it would be nice to keep it consistent
There was a problem hiding this comment.
Log structure fixed to be consistent with others
No description provided.