Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added description to assign to benchmark flow #241

Merged
merged 8 commits into from
Nov 12, 2023

Conversation

tessathornberry
Copy link
Contributor

@tessathornberry tessathornberry commented Nov 9, 2023

Added some CSS and beginning of conditional rendering for second half of modal.

}

export const SubgoalAssignmentModal = (props: SubgoalAssignmentModalProps) => {
const [selectedParaIds, setSelectedParaIds] = useState<string[]>([]);
const [currentModalSelection, setCurrentModalSelection] = useState(1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐧 maybe something like

Suggested change
const [currentModalSelection, setCurrentModalSelection] = useState(1);
const [currentModalSelection, setCurrentModalSelection] = useState<"PARA_SELECTION" | "SCHEDULING">("PARA_SELECTION");

to make this a little more clear

@codetheweb codetheweb merged commit e755537 into main Nov 12, 2023
3 checks passed
@codetheweb codetheweb deleted the feat-para-assignment-dialog-02 branch November 12, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants