9 setup github actions #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rooiss
commented
Feb 2, 2024
rooiss
commented
- it seems the test is working as intended, I wasn't entirely sure what workflows we're trying to implement given our current project
|
@francisli I added the prettier and linter checks on push and it seems to be working with our configs. I'm still not entirely sure if this is how the implementation is supposed to be. Let me know what kind of adjustments are needed if any. |
francisli
approved these changes
Feb 24, 2024
There was a problem hiding this comment.
Thanks for getting this up and running... I've made some changes to "containerize" the job so that we can also launch a db container for tests, and added a test step.
I'm temporarily disabling the test step until we integrate network mocks... the CA license server is down for maintenance over the weekend so the tests are failing...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.