Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactor: mobile map school card #284

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

yjshin229
Copy link
Collaborator

const SchoolImage = (props: any) => (
<Image
src={props.src}
alt={props.alt}
placeholder="blur"
blurDataURL={blurDataURL}
width={1000}
height={500}
className={h-40 max-h-[20vh] rounded-l-2xl object-cover md:max-h-none md:rounded-b-lg md:rounded-t-2xl ${props.className ? props.className : ""}}
/>
);

image

Is there a reason why the image's max height is set to 20vh here?
This is causing a blank space in the card when the card height is longer. (it becomes longer when it has the high priority badge or the school name is long + the learn more button)

Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
support-sfusd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 9:51am

@yjshin229 yjshin229 added the question Further information is requested label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant