[WIP] Refactor: mobile map school card #284
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
const SchoolImage = (props: any) => (
<Image
src={props.src}
alt={props.alt}
placeholder="blur"
blurDataURL={blurDataURL}
width={1000}
height={500}
className={
h-40 max-h-[20vh] rounded-l-2xl object-cover md:max-h-none md:rounded-b-lg md:rounded-t-2xl ${props.className ? props.className : ""}
}/>
);
Is there a reason why the image's max height is set to 20vh here?
This is causing a blank space in the card when the card height is longer. (it becomes longer when it has the high priority badge or the school name is long + the learn more button)