[CI] tests: update with narrow no-break space in date format #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A NNBS is now used it seems before the AM/PM indicator since recent update of libraries. A correct approach is to avoid updates in CI, always use fixed versions for libraries thanks to compositors lock files. Signed-off-by: Thibaud CANALE <[email protected]>
Yes, #2121 is a better fix, however I thought I could first simply update the test to match those new updates but it didn’t meet the expectations as more test failures happened, and I don’t know why. I still think this test update is required if we decide to pull current third-party updates, so I would say let it as-is for now on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A NNBS (narrow no-break space) is now used it seems before the AM/PM indicator since recent update of libraries.
A correct approach is to avoid updates in CI, always use fixed versions for libraries thanks to compositors lock files.
This is very close to a workaround than an actual fix.