Corrections in vulnerability action triggering new release #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaschaSchwarze0
added
the
kind/cleanup
openshift-ci
bot
added
the
release-note-none
pull-request-size
bot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HeavyWombat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Signed-off-by: Sascha Schwarze <[email protected]>
SaschaSchwarze0
force-pushed
the
sascha-correct-comment-text
branch
from
997c3ac to
2727d56
Compare
SaschaSchwarze0
changed the title
SaschaSchwarze0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The report vulnerabilities action today correctly determined that everything is fixed and triggered a new release automatically. Though, the comment in #1742 (comment) was not accurate as it stated the wrong tag. Correcting this.
Also, the action (https://github.com/shipwright-io/build/actions/runs/12683451116) ran with the workflow definition from the main branch. It should have been the release branch. This did not matter this time because the release workflow was not changed. But it can matter in the future. I am also correcting this.
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes