Fix gh command that closes the issue when all vulnerabilities are fixed #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
release-note-none
pull-request-size
bot
added
the
size/XS
Signed-off-by: Sascha Schwarze <[email protected]>
SaschaSchwarze0
force-pushed
the
sascha-fix-issue-close
branch
from
197181d to
9537c71
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The scheduled workflow run this morning failed to close the issue because the
ghcommand was not correct.I corrected this, tried it out here and the issue was closed successfully.
I have also added an event trigger to the workflow so that it runs when a release is published or edited (which potentially means that it was marked latest). Therefore the action will close the vulnerabilities issues earlier and not (only) in the nightly run that comes next.
Submitter Checklist
Release Notes