Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/drawer|inputgroup): fixed drawer display issue #1561

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

ridvandmrc
Copy link
Contributor

@ridvandmrc ridvandmrc commented Nov 13, 2024

💡 What is the current behavior?

  • initial drawer display style is none so that child cannot calculate its width or height.
  • because if parent is disable that means that child cannot calculate from DOM

GitHub Issue Number: #1551

🆕 What is the new behavior?

  • Updated drawer style and refactored input-group

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: be42e9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ridvandmrc ridvandmrc force-pushed the fix/1551-drawer-style-issue branch from 752cc62 to 87e0a0c Compare November 28, 2024 13:27
@ridvandmrc
Copy link
Contributor Author

It has tested and verified with new version.

<ix-drawer>
      <ix-input-group>
        <input type="text" value="input text" />
        <span slot="input-start"><ix-icon name="about" size="16"></ix-icon></span>
      </ix-input-group>
      <ix-input value="test value" >

        <ix-icon name="success" slot="start"></ix-icon>
    </ix-input>
    </ix-drawer>

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

packages/core/src/components/input-group/input-group.tsx Outdated Show resolved Hide resolved
.changeset/proud-waves-care.md Outdated Show resolved Hide resolved
packages/core/src/components/drawer/drawer.tsx Outdated Show resolved Hide resolved
packages/core/src/components/drawer/drawer.tsx Outdated Show resolved Hide resolved
@@ -20,17 +20,19 @@
visibility: hidden;

display: flex;
position: absolute;
position: fixed;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically a breaking change. Can we do without that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't use position: fixed, it wil have scroll problem for long page like:
image

position:absolute, gets body as a reference so, it will have horizontal problem while presenting the drawer (only animation).
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure it is really breaking change, because this will not affect user behavior, it does not break anything I guess

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think these are not important, we can keep as 'position:absolute'.

packages/core/src/tests/drawer/drawer.e2e.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@matthiashader matthiashader force-pushed the fix/1551-drawer-style-issue branch from 013cef9 to 98764ce Compare January 8, 2025 10:09
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBD when will ix-input-group be deprecated/removed?

packages/core/src/components/input-group/input-group.tsx Outdated Show resolved Hide resolved
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants