-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core/drawer|inputgroup): fixed drawer display issue #1561
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: be42e9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
752cc62
to
87e0a0c
Compare
It has tested and verified with new version. <ix-drawer>
<ix-input-group>
<input type="text" value="input text" />
<span slot="input-start"><ix-icon name="about" size="16"></ix-icon></span>
</ix-input-group>
<ix-input value="test value" >
<ix-icon name="success" slot="start"></ix-icon>
</ix-input>
</ix-drawer> |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
@@ -20,17 +20,19 @@ | |||
visibility: hidden; | |||
|
|||
display: flex; | |||
position: absolute; | |||
position: fixed; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is technically a breaking change. Can we do without that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure it is really breaking change, because this will not affect user behavior, it does not break anything I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you think these are not important, we can keep as 'position:absolute'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
013cef9
to
98764ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBD when will ix-input-group
be deprecated/removed?
Quality Gate passedIssues Measures |
💡 What is the current behavior?
GitHub Issue Number: #1551
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs
)pnpm test
)pnpm lint
)pnpm build
, changes pushed)👨💻 Help & support