-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reflect button properties to 'date-dropdown' and 'expanded-search' #1635
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: aadefbb The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create interface for all button like components and have them implement it (compare IxDatePickerComponent)
/** | ||
* Loading button | ||
*/ | ||
@Prop() loading: boolean = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No effect? Can be omitted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this does not make any sense. Let's omit it :)
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we remove the CSS transition
from .btn-search
the collapse animation feels less weird. We should consult a designer 😆
'@siemens/ix-vue': minor | ||
--- | ||
|
||
reflect button properties to 'date-dropdown' and 'expanded-search' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reflect button properties to 'date-dropdown' and 'expanded-search' | |
Add additional button properties to **ix-date-dropdown** and **ix-expanding-search**. |
💡 What is the current behavior?
GitHub Issue Number: Closes #1552, [IX-1941]
🆕 What is the new behavior?
🎵 Note
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs
)pnpm test
)pnpm lint
)pnpm build
, changes pushed)👨💻 Help & support