Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reflect button properties to 'date-dropdown' and 'expanded-search' #1635

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Jan 8, 2025

💡 What is the current behavior?

  • date-dropdown has only 'primary' button style (no ghost, outline,.. props)
  • expanding-search has only 'primary' button style (no ghost, outline,.. props)
  • -> styling button properties are not reflected to the components that utilizes the ix-button

GitHub Issue Number: Closes #1552, [IX-1941]

🆕 What is the new behavior?

  • button properties (for styling) are reflected in the components that utilize the ix-button
  • button of date-dropdown can be styled like a button
  • button of expanding-search can be styled like a button

🎵 Note

  • Check naming -> 'button-ghost' okay, or better 'ghost'?
  • buttonGhost in expanding-search is defaultwise true, but stencil recommends properties to be false by default -> better to set it to '?' and if not initialised it will get set to true in componentWillLoad?

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Jan 8, 2025

🦋 Changeset detected

Latest commit: aadefbb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix-angular Minor
@siemens/ix Minor
@siemens/ix-vue Minor
@siemens/ix-aggrid Patch
@siemens/ix-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create interface for all button like components and have them implement it (compare IxDatePickerComponent)

/**
* Loading button
*/
@Prop() loading: boolean = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No effect? Can be omitted?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work as expected:
image
But the question is, is this really necessary?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this does not make any sense. Let's omit it :)

packages/core/src/tests/date-dropdown/basic/index.html Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Jan 9, 2025

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we remove the CSS transition from .btn-search the collapse animation feels less weird. We should consult a designer 😆

'@siemens/ix-vue': minor
---

reflect button properties to 'date-dropdown' and 'expanded-search'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
reflect button properties to 'date-dropdown' and 'expanded-search'
Add additional button properties to **ix-date-dropdown** and **ix-expanding-search**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button styling for Date dropdown, Dropdown, Expanding search
2 participants