Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] keep hook annotations for crds installed from upstream operator chart #1620

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

jinja2
Copy link
Collaborator

@jinja2 jinja2 commented Jan 16, 2025

Description:

Keep hook annotations to unblock helm upgrades for existing operator installations using upstream installations.
In a previous commit we removed these annotations but see upgrades fail. On upgrade helm sees the object exists but it is not part of tracked objects in its release and throws below error

Error: UPGRADE FAILED: Unable to continue with update: Instrumentation "sock-splunk-otel-collector" in namespace "default" exists and cannot be imported into the current release: invalid ownership metadata; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "sock"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "default"

The alternative is to ask users to add below annotations to instrumentation objects which were created as hook to add them to helm release

meta.helm.sh/release-name
meta.helm.sh/release-namespace

OR ask users to delete the instrumentation object created by hook and let upgrade create a new one.

Link to Splunk idea: <Link to Splunk idea, see https://ideas.splunk.com>

Testing:

Documentation:

@jvoravong
Copy link
Contributor

Just to share. We would need many of the template changes from #1586. Happy to chat as needed.

@jinja2 jinja2 changed the title keep hook annotations for crds installed from upstream operator chart [chore] keep hook annotations for crds installed from upstream operator chart Jan 16, 2025
@jinja2 jinja2 marked this pull request as ready for review January 16, 2025 19:54
@jinja2 jinja2 requested review from a team as code owners January 16, 2025 19:54
@jinja2 jinja2 closed this Jan 17, 2025
@jinja2 jinja2 reopened this Jan 17, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
@jinja2 jinja2 merged commit 6f8d5a6 into main Jan 17, 2025
119 of 122 checks passed
@jinja2 jinja2 deleted the add-conditional-hook branch January 17, 2025 01:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants