[chore] keep hook annotations for crds installed from upstream operator chart #1620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Keep hook annotations to unblock helm upgrades for existing operator installations using upstream installations.
In a previous commit we removed these annotations but see upgrades fail. On upgrade helm sees the object exists but it is not part of tracked objects in its release and throws below error
The alternative is to ask users to add below annotations to instrumentation objects which were created as hook to add them to helm release
OR ask users to delete the instrumentation object created by hook and let upgrade create a new one.
Link to Splunk idea: <Link to Splunk idea, see https://ideas.splunk.com>
Testing:
Documentation: