Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review for inital release #1

Merged
merged 14 commits into from
Sep 9, 2024
Merged

Review for inital release #1

merged 14 commits into from
Sep 9, 2024

Conversation

christof-ochs
Copy link
Collaborator

No description provided.

@christof-ochs christof-ochs requested a review from BeckerStS July 30, 2024 11:57
@christof-ochs christof-ochs requested review from sjuergen and BeckerStS and removed request for BeckerStS and sjuergen July 30, 2024 12:46
@sjuergen sjuergen requested review from sjuergen and BeckerStS and removed request for BeckerStS and sjuergen July 31, 2024 09:44
@BeckerStS
Copy link
Contributor

@christof-ochs

THX for the contribution :)

Review-comments:

  • pls. add some tests to the repository
  • pls. adjust the namespace to fit the Namespace of the community like "Simatic.Ax.StringBuilder"
    (this might be debateable @sjuergen what you think ?, community pkg's that extent the "system" ?)
  • pls. describe more in details why using this is more convenient in comparison to the native system.string usage for the user (point out the benefits)
  • pls. mention the available methods on the Readme.md
  • optional: would be great if you could add the other string operations as methods as well

Greetings
Stefan

@BeckerStS
Copy link
Contributor

committed a fix to the example program in the Readme.md

@christof-ochs
Copy link
Collaborator Author

@BeckerStS thank you for the feedback.
I adjusted the following topics in the last commits:

  • added tests
  • describe benefit of using fluent interface in Readme
  • add table of methods to the readme

I would appreciate if you could clarify the namespace topic. I would prefer the current extension of the System.Strings NS

@sjuergen
Copy link
Contributor

sjuergen commented Aug 14, 2024

@BeckerStS @christof-ochs
Regarding the namespace: System.Strings is already used in the system libraries on @ax. That could be lead to a misunderstanding from my point of view. Another reason: What happens when the System.Strings library will be extended by a string builder class?

@christof-ochs
Copy link
Collaborator Author

@sjuergen
The way you phrased that it sounds like you assumed the namespace is identical by accident. Just to make clear my intend: I selected it by choice. The reasoning is, that the functionality exclusively works on the content of that library and extends it.

but if you want to have a different ns, i can of course adapt it.

@sjuergen
Copy link
Contributor

I have a preference. But I'm open for other arguments. I understand your point. I would like to discuss it with the team. @theBadT have you any opinion on it?

@christof-ochs
Copy link
Collaborator Author

@BeckerStS I also added the other string operations from the System.Strings library

@BeckerStS BeckerStS merged commit 631a83a into main Sep 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants