Add c++ jump fixing and finding of slow jumps #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhasself
requested changes
Jan 13, 2025
mmccrackan
previously approved these changes
Jan 15, 2025
Comment on lines
+911
to
+920
| for (auto const &r: ranges[di].segments) { | ||
| start = di*nsamp + r.first; | ||
| for(int j = stop; j < start && to_sub != 0; j++) { | ||
| output[j] = tod_data[j] - to_sub; | ||
| } | ||
| stop = di*nsamp + r.second; | ||
| min_h = *(std::min_element(jump_heights+start, jump_heights+stop)); | ||
| max_h = *(std::max_element(jump_heights+start, jump_heights+stop)); | ||
| // Decide whether this is a negative or positive jump. | ||
| height = (abs(min_h) > abs(max_h)) ? min_h : max_h; |
There was a problem hiding this comment.
I think the answer is yes, but is this okay if there is a jump at the first or last samples?
There was a problem hiding this comment.
Yeah thats fine, the mean level will shift to around the first sample's value in that case, but that should be ok since we will want to mean sub after gapfilling anyways.
mhasself
approved these changes
Jan 15, 2025
Stupid diffs giving away my love for black... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a draft because my so3g build system is broken rn...