Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent duplicate declaration in firewalld_ipset #50

Merged
merged 1 commit into from
May 1, 2024
Merged

Prevent duplicate declaration in firewalld_ipset #50

merged 1 commit into from
May 1, 2024

Conversation

silug
Copy link
Contributor

@silug silug commented Apr 29, 2024

Fixes #49

@silug silug marked this pull request as draft April 29, 2024 18:04
@silug silug marked this pull request as ready for review April 30, 2024 20:53
nick-markowski
nick-markowski approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@nick-markowski nick-markowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes tested in local environment

@silug silug merged commit 115c071 into simp:master May 1, 2024
11 checks passed
@silug silug deleted the issue_49 branch May 1, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-riddle michael-riddle michael-riddle approved these changes

@nick-markowski nick-markowski nick-markowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Org Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate declaration in firewalld_ipset
3 participants
@silug @nick-markowski @michael-riddle