Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes and improvements #215

Merged
merged 6 commits into from
Jul 12, 2019
Merged

Minor fixes and improvements #215

merged 6 commits into from
Jul 12, 2019

Conversation

tschoonj
Copy link
Contributor

Ran into some problems as I was setting up the server, thought they may be helpful to others as well.

vsoch
vsoch requested changes Jul 12, 2019
View reviewed changes
scripts/generate_cert.sh Outdated Show resolved Hide resolved
@vsoch
Copy link
Member

vsoch commented Jul 12, 2019

Also for the server we have a CHANGELOG.md and the version string is in the VERSION file.

tschoonj added 3 commits July 12, 2019 12:57
@tschoonj
generate_cert.sh: fixes
b090c14 
* run certbot with sudo
* use ${DOMAIN} variable to determine path to certificates
@tschoonj
docs.install.server: add clarification
9b6481c
@tschoonj
docs.setup: fix typo
8154fbd
vsoch
vsoch reviewed Jul 12, 2019
View reviewed changes
scripts/generate_cert.sh Outdated Show resolved Hide resolved
vsoch
vsoch reviewed Jul 12, 2019
View reviewed changes
VERSION Outdated Show resolved Hide resolved
@vsoch
Copy link
Member

vsoch commented Jul 12, 2019

Ready for merge?

@tschoonj
Copy link
Contributor Author

nope, gimme a minute

@tschoonj
Copy link
Contributor Author

Ready when you are...

@tschoonj
Copy link
Contributor Author

By the way: next week we are going to deploy a singularity registry instance on our K8S cluster... Have you ever tried doing that?

@vsoch
Copy link
Member

vsoch commented Jul 12, 2019

I personally haven't, but others have: sylabs/singularity-cri#321

I don't have a bunch of servers to throw around and test, but I'd hugely like to support this! So whatever help you need, development work, etc., count me in.

@vsoch vsoch merged commit e61a345 into singularityhub:master Jul 12, 2019
@tschoonj
Copy link
Contributor Author

I personally haven't, but others have: sylabs/singularity-cri#321

I don't have a bunch of servers to throw around and test, but I'd hugely like to support this! So whatever help you need, development work, etc., count me in.

I will keep your kind offer in mind should the need arise for your assistance 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsoch vsoch vsoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tschoonj @vsoch