Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Multiple Media Form Field #1235

Merged
merged 5 commits into from
Apr 24, 2021
Merged

Add Multiple Media Form Field #1235

merged 5 commits into from
Apr 24, 2021

Conversation

AlexGStapleton
Copy link
Member

@AlexGStapleton AlexGStapleton commented Jan 13, 2021 •
edited
Loading

Resolve #877

Screenshot:
2021-02-08_18-37-29-1412

@AlexGStapleton AlexGStapleton self-assigned this Jan 13, 2021
@AlexGStapleton
Copy link
Member Author

I've created a quick test wide to test this form field. You can download it by clicking here. Once installed navigate to Plugins > SiteOrigin Widgets and activate the SiteOrigin Multiple Media Test widget. The widget will output an array on the frontend.

@AlexGStapleton
Copy link
Member Author

AlexGStapleton commented Feb 9, 2021 •
edited
Loading

The last commit changes the Add Media button to use the WP .button styling. This styling respects the users selected Admin Color Scheme.

Screenshot_2021-02-10 Edit Page ‹ SiteOrigin — WordPress(2)

@AlexGStapleton AlexGStapleton marked this pull request as ready for review February 17, 2021 04:53
@AlexGStapleton
Copy link
Member Author

I've logged an issue about introducing repeater support in a future update:

#1250

@Misplon Misplon self-requested a review March 4, 2021 12:41
@Misplon Misplon requested a review from gregpriday March 5, 2021 09:19
gregpriday
gregpriday approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@gregpriday gregpriday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see any issues with this code. As usual, as long as it's been well tested, we're all good to go here.

@Misplon Misplon merged commit fac10df into develop Apr 24, 2021
@Misplon Misplon deleted the multiple-media-form-field branch April 24, 2021 15:14
@AlexGStapleton AlexGStapleton mentioned this pull request May 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregpriday gregpriday gregpriday approved these changes

@Misplon Misplon Misplon approved these changes

Assignees

@AlexGStapleton AlexGStapleton

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-image Upload Field
3 participants
@AlexGStapleton @Misplon @gregpriday