Skip to content

Commit

Permalink
Skip installing green2url by default in the Docker container
Browse files Browse the repository at this point in the history
  • Loading branch information
soulgalore committed Jan 7, 2025
1 parent 9597140 commit 60d062c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
36.0.0 will be released late Januart 2025.

### Breaking
* Only download green2url data when you specifically ask for it [#4354](https://github.com/sitespeedio/sitespeed.io/pull/4354). The Docker container [#4356](https://github.com/sitespeedio/sitespeed.io/pull/4356) will still have the data but installing using npm you need to run `DOWNLOAD_URL2GREEN=true npm install sitespeed.io`. The green2url is also updated to use the latest availible data by late 2024.
* Only download green2url data when you specifically ask for it [#4354](https://github.com/sitespeedio/sitespeed.io/pull/4354). To install you need to run `DOWNLOAD_URL2GREEN=true npm install sitespeed.io`. The green2url is also updated to use the latest availible data by late 2024. This saves 80 mb in default downloading.
* Make sure you can't run with both `--cpu` and `--collectProfileRun` since that do not make any sense [#4298](https://github.com/sitespeedio/sitespeed.io/pull/4298)
* Use correct name in Browsertime: userTimingAllowList instead of whitelist [#4346](https://github.com/sitespeedio/sitespeed.io/pull/4346).
* Plugins need to update the plugin dependency to @sitespeed.io/plugin 1.0.0 or higher.
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ WORKDIR /usr/src/app
COPY package.json /usr/src/app/
COPY npm-shrinkwrap.json /usr/src/app/
COPY tools/postinstall.js /usr/src/app/tools/postinstall.js
RUN DOWNLOAD_URL2GREEN=true npm install --production && npm cache clean --force
RUN npm install --production && npm cache clean --force
COPY . /usr/src/app

COPY docker/scripts/start.sh /start.sh
Expand Down

0 comments on commit 60d062c

Please sign in to comment.