Refactor address validation: update isAddress method to return Contra…

…ctAddress type for improved type safety
skalenetwork · Jan 9, 2025 · 042560e · 042560e
1 parent a1e10e1
commit 042560e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/typescript/ethers-v5/src/ethers5Adapter.ts b/typescript/ethers-v5/src/ethers5Adapter.ts
@@ -5,6 +5,9 @@ import {
     FunctionCall
 } from "@skalenetwork/skale-contracts";
 import { BaseContract, ethers } from "ethers";
+import {
+    ContractAddress
+} from "@skalenetwork/skale-contracts/lib/domain/types";
 import { Provider } from "@ethersproject/providers";
 
 
@@ -47,7 +50,7 @@ export class Ethers5Adapter implements Adapter<BaseContract> {
     }
 
     // eslint-disable-next-line class-methods-use-this
-    isAddress (value: string): boolean {
+    isAddress (value: string): value is ContractAddress {
         return ethers.utils.isAddress(value);
     }
 }
diff --git a/typescript/ethers-v6/src/ethers6Adapter.ts b/typescript/ethers-v6/src/ethers6Adapter.ts
@@ -5,6 +5,9 @@ import {
     FunctionCall
 } from "@skalenetwork/skale-contracts";
 import { BaseContract, Provider, ethers } from "ethers";
+import {
+    ContractAddress
+} from "@skalenetwork/skale-contracts/lib/domain/types";
 
 
 export class Ethers6Adapter implements Adapter<BaseContract> {
@@ -46,7 +49,7 @@ export class Ethers6Adapter implements Adapter<BaseContract> {
     }
 
     // eslint-disable-next-line class-methods-use-this
-    isAddress (value: string): boolean {
+    isAddress (value: string): value is ContractAddress {
         return ethers.isAddress(value);
     }
 }