Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1900 remove debug symbols release #2072

Open
wants to merge 5 commits into
base: v4.0.0
Choose a base branch
from
Open

Feature/1900 remove debug symbols release #2072

wants to merge 5 commits into from

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Jan 8, 2025 •
edited
Loading

fixes #1900

  1. All dependencies, are built with -O3 and without -g
  2. skaled is built with -O3 but WITH -g.
  3. -rdynamic removed.
  4. skaled binary is stripped, but it's copy wit debug info is kept.
  5. asserts are removed from RelWithDebInfo build

Consequences:

  1. Stack trace printed by skaled on crash will not contain any function names.
  2. gdb will be able to use skaled-debug file to load debug info for original skaled
  3. addr2line will be able to convert addresses from skaled's printed stack trace into source code locations using skaled-debug binary

Testing:
1

objdump -h skaled | grep debug
nm -a skaled
  1. Execute strip command on skaled and see that it's size didn't change
  2. ojdump -h | grep debug on all project libraries shows no result too.

skaled binary size 29575576

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@olehnikolaiev olehnikolaiev linked an issue Jan 8, 2025 that may be closed by this pull request
Remove debug library builds from release #1900
Open
DmytroNazarenko
DmytroNazarenko requested changes Jan 16, 2025
View reviewed changes
.github/workflows/setup-build-publish.yml
Comment on lines +153 to +159
if [[ "$BUILD_TYPE" = "Release" ]]; then
debug_wc=$(objdump -h skaled/skaled | grep -i debug | wc -l)
sym_wc=$(readelf -s skaled/skaled | wc -l)
if (( debug_wc != 0 || sym_wc > 10000 )); then
exit 1
fi
fi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

custom_build.yml needs to be modified to support Release option

.github/workflows/publish.yml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Propose to use setup-build-publish.yml workflow underneath with Release parameter

@DmytroNazarenko DmytroNazarenko added this to the SKALE 4.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmytroNazarenko DmytroNazarenko DmytroNazarenko requested changes

@kladkogex kladkogex Awaiting requested review from kladkogex kladkogex is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
SKALE 4.0
Development

Successfully merging this pull request may close these issues.

Remove debug library builds from release
2 participants
@olehnikolaiev @DmytroNazarenko