lsp: Rename components, structs and enum from places where they are used #7305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and their usages and imports/exports
|
It mostly works when testing from VSCode, but it still has a couple of rough edges where the tests pass, but VSCode does not want to trigger. I'll poke at it a bit more tomorrow. |
ogoffart
reviewed
Jan 9, 2025
| .child_token(SyntaxKind::StringLiteral) | ||
| .map(|t| t.text().trim_matches('"').to_string())?; | ||
|
|
||
| if import == "std-widgets.slint" || import == "std-widgets.s60" { |
There was a problem hiding this comment.
Suggested change
| if import == "std-widgets.slint" || import == "std-widgets.s60" { | |
| if import == "std-widgets.slint" { |
It was called sixtyfps_widgets.60 but we no longer support that
| Foo /* <- TEST_ME_9 */ { } | ||
| } | ||
|
|
||
| function Foo(Foo: int) { Foo + 1; } |
There was a problem hiding this comment.
The test should also test that none of the Foo here matches with a component.
| } | ||
|
|
||
| impl DeclarationNodeQuery { | ||
| fn new(node: SyntaxNode) -> Option<Self> { |
There was a problem hiding this comment.
This seems like it is an incomplete duplication of language::token_info::token_info()
That function also do the lookup and tell you the exact type this is referring to.
So I think it would be a better candidate.
|
I started to pull out a bit of code from here into easier to review portions in separate PRs... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has pretty decent test coverage, but it is more involved than the first and it is admittedly a bit of a mess in the PR...
I was test driven and forgot to stop along the way ;-)