lsp: Simplify tests for renaming #7309
Conversation
| let identifier = en.DeclaredIdentifier(); | ||
| if identifier.text() == name { | ||
| result.push(identifier); | ||
| #[track_caller] |
There was a problem hiding this comment.
The function have many unwrap. It may be difficult to distinguish them if they are all reported at the location of the caller. But I guess this is not a problem in practice anyway as it is more important to know what fails rather than why
There was a problem hiding this comment.
I found it more convenient this way: The test print the processed output and which file that was taken from already and it typically is pretty obvious what I mistyped with that visible :-)
| let document = document_cache.get_document_by_path(document_path).unwrap(); | ||
| let document = document.node.as_ref().unwrap(); | ||
| let comment = document | ||
| .descendants_with_tokens() |
There was a problem hiding this comment.
What I'm usually doing in the other tests is to just call find() on the source string to get the offset, and then find the token from the offset
There was a problem hiding this comment.
Yeap, that makes sense :-) I'll change that.
Simplify the testing of the renaming and some more small patches that should be pretty uncontroversial.