Enable muda macOS menubar on macOS #7312
Merged
+77
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
force-pushed
the
simon/macos-menubar-tweaks
branch
2 times, most recently
from
75e57ae to
481e206
Compare
ogoffart
approved these changes
Jan 9, 2025
tronical
force-pushed
the
simon/macos-menubar-tweaks
branch
from
481e206 to
c5cd488
Compare
|
Does muda will be used as a backend for #38? If yes I wonder what is the plan for Linux since AFAIK muda requires a GTK window. |
Hide the winit menu bar and provide a fallback if the app doesn't provide one. Also, activate per window to fix support for multiple windows.
tronical
force-pushed
the
simon/macos-menubar-tweaks
branch
from
c5cd488 to
7c1ef97
Compare
The plan for Linux is not to use Muda (exactly because, among other things, Gtk and winit can't be combined) and instead the menu bar and context menus are implemented in Slint natively. |
ogoffart
reviewed
Jan 10, 2025
| #[allow(unused_mut)] | ||
| let mut default_builder = winit::event_loop::EventLoop::with_user_event(); | ||
| #[cfg(all(feature = "muda", target_os = "macos"))] | ||
| winit::platform::macos::EventLoopBuilderExtMacOS::with_default_menu( |
There was a problem hiding this comment.
So if the user set an event_loop_builder (using the private API) the menu won't be visible. I believe we probably should disable the default_menu even if there is already an event_loop_builder. No?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide the winit menu bar and provide a fallback if the app doesn't provide one. Also, activate per window to fix support for multiple windows.