ResultTable: HeaderCell and Cell rendering tweaks #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not wrap `HeaderCell` children in a `span` by default because it makes providing a custom `HeaderCell` harder. - Support `headerCellProps` and `cellProps` to accomodate the very common pattern of needing to only pass props to the header/cell components.
🦋 Changeset detectedLatest commit: 6d0e89a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| }, | ||
| j | ||
| ) => ( | ||
| <HeaderCell key={j} colSpan={colspan} {...headerCellProps}> | ||
| <span> |
There was a problem hiding this comment.
Shouldn't this span be removed also here?
There was a problem hiding this comment.
Indeed. Thanks for catching this 👍
conraddavisjr
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
There are quite a few things that I'm not in favor of regarding the structure of these components... and I suspect you feel similarly. However, this is an improvement, and one that we should make iteratively, instead of trying to do a huge lift. Thanks for your initiative on this @stellarhoof!
I'd like to get one more review & approval on this from @positiveVibes4all before merging.
positiveVibes4all
approved these changes
Jun 18, 2024
|
Coverage after merging cell-rendering-tweaks into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HeaderCellchildren in aspanby default because it makes overridingHeaderCellharder.headerCellPropsandcellPropsto accomodate the very common pattern of needing to only pass props to the header/cell components.