Add missing client types #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are lots of new example types in contexture-elasticsearch that had not been accounted for in contexture-client.
🦋 Changeset detectedLatest commit: 18f8402 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Coverage after merging feature/add-missing-client-types into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
JBezerra
reviewed
Jun 20, 2024
| @@ -360,4 +360,87 @@ export default F.stampKey('type', { | |||
| search: null, | |||
| }, | |||
| }, | |||
| dateIntervalGroupStats: { | |||
| reactors: { | |||
| groupField: 'self', | |||
There was a problem hiding this comment.
For my education, looking at the file I usually see self, others and all as valid values, what do they mean?
There was a problem hiding this comment.
These values tell contexture-client what to mark as "dirty" when that property changes
selfmeans mark the node the property belongs to as "dirty"othersmeans mark nodes that depend on the node the property belongs to as "dirty"allis a combination of bothselfandothers
A node is a contexture tree node. For example one of these: https://github.com/smartprocure/contexture/blob/main/packages/client/src/listeners.test.js#L22-L27
If this all sounds confusing then you're not alone. It's not a complicated mental model, we just don't have TypeScript types or good enough documentation in these packages today.
There was a problem hiding this comment.
Love it! Could you clarify what do you mean by "dirty", or, when can we consider a node is "dirty"?
There was a problem hiding this comment.
Dirty means that we need to call the backend to get results for that node. The contexture-client library can either submit debounced backend requests when nodes are marked as "dirty" or it can wait for the user to click "Search" to send the request.
JBezerra
approved these changes
Jun 24, 2024
|
@JBezerra Thanks for the review! |
positiveVibes4all
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are lots of new example types in contexture-elasticsearch that had not been accounted for in contexture-client.