Fix regression in contexture-elasticsearch error handling #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix regression introduced in [a previous PR](#244) where deleting the `meta` property of a [ResponseError](https://github.com/elastic/elasticsearch-js/blob/7.x/lib/errors.js#L123) in elastic clients previous to v8 will cause a bug in [its string representation](https://github.com/elastic/elasticsearch-js/blob/7.x/lib/errors.js#L123).
|
stellarhoof
requested review from
conraddavisjr,
ccalbaugh,
JBezerra and
positiveVibes4all
|
Coverage after merging feature/fix-error-bug into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
stellarhoof
changed the title
positiveVibes4all
approved these changes
Aug 6, 2024
stellarhoof
pushed a commit
that referenced
this pull request
Aug 6, 2024
Forgot to add changelog for #246
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression introduced in a previous PR where deleting the
metaproperty of a ResponseError will cause a bug in its string representation.This fix only applies to elastic clients previous to v8.