GS-8167 Migrate from jest to vitest #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sandhya-spend
commented
Sep 19, 2024
| '<rootDir>/packages/*/src/**/*.js', | ||
| '!<rootDir>/packages/*/src/**/*.test.js', | ||
| ], | ||
| reporters: ['default', ['github-actions', { silent: false }]], |
There was a problem hiding this comment.
In vite, github-actions is default.
sandhya-spend
commented
Sep 19, 2024
| coverageReporters: ['lcov'], | ||
| collectCoverageFrom: [ | ||
| '<rootDir>/packages/*/src/**/*.js', | ||
| '!<rootDir>/packages/*/src/**/*.test.js', |
There was a problem hiding this comment.
All test files are excluded from coverage.
|
Hey @sandhya-spend can we review that? If so, can you move to |
I am checking that the ci runs well, thats why its in draft. |
sandhya-spend
commented
Sep 19, 2024
| /* https://jestjs.io/docs/configuration */ | ||
|
|
||
| export default { | ||
| coverageProvider: 'v8', |
There was a problem hiding this comment.
v8 is the default coverage provider.
sandhya-spend
requested review from
stellarhoof,
conraddavisjr,
JBezerra,
positiveVibes4all and
PranitaJainB
stellarhoof
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
- Coverage is reported in PR
- Tests run both globally and per package
🎉 🎉 🎉 Outstanding work! There was nothing I could find fault with this work, just a couple of comments.
The tests run even faster now and it on top of that, it allow us to more easily introduce TypeScript!
.github/workflows/pull-request.yaml
Outdated
| run: yarn run jest --ci --reporters github-actions --reporters summary --coverage . | ||
| env: | ||
| NODE_OPTIONS: '--no-warnings --experimental-vm-modules' | ||
| run: yarn run test --reporter github-actions --reporter default --coverage |
There was a problem hiding this comment.
suggestion: Remove reporters configuration
github-actions is the default when running in CI and default is well, the default.
There was a problem hiding this comment.
Oops, missed it.
| process.env.VITE_MONGO_URI = global.__mongoServer.getUri() | ||
| } | ||
|
|
||
| // https://nodkz.github.io/mongodb-memory-server/docs/guides/integration-examples/test-runners/ |
There was a problem hiding this comment.
Here's the updated, working link: https://typegoose.github.io/mongodb-memory-server/docs/guides/integration-examples/test-runners
|
Coverage after merging GS-8167/vitest into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GS-8167
Update repo to use
vitestinstead ofjest.Note:
mobximports have the warningThis is resolved in a later version of
mobxand needs to be separate task.