Fix panic when peer doesn't have block (#1303)

* Fix panic when peer doesn't have block * PR link
smol-dot · Nov 5, 2023 · 2eee81b · 2eee81b
1 parent f531a33
commit 2eee81b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/light-base/src/sync_service.rs b/light-base/src/sync_service.rs
@@ -358,8 +358,8 @@ impl<TPlat: PlatformRef> SyncService<TPlat> {
                 )
                 .await
             {
-                Ok(b) => b,
-                Err(_) => continue,
+                Ok(b) if !b.is_empty() => b,
+                Ok(_) | Err(_) => continue,
             };
 
             return Ok(result.remove(0));
@@ -404,8 +404,8 @@ impl<TPlat: PlatformRef> SyncService<TPlat> {
                 )
                 .await
             {
-                Ok(b) => b,
-                Err(_) => continue,
+                Ok(b) if !b.is_empty() => b,
+                Ok(_) | Err(_) => continue,
             };
 
             return Ok(result.remove(0));

diff --git a/wasm-node/CHANGELOG.md b/wasm-node/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Fixed
+
+- Fix panic when requesting a block with a specific hash from the peer-to-peer network and none of the peers has the block. ([#1303](https://github.com/smol-dot/smoldot/pull/1303))
+
 ## 2.0.7 - 2023-11-02
 
 ### Changed