MDL-80231 core_ltix: cleaning up code sniffer issues in ltix helper

lang/en/ltix.php

@@ -171,7 +171,6 @@
 $string['no_tp_configured'] = 'There are no unregistered external tool registrations configured.';
 $string['no_tp_pending'] = 'There are no pending external tool registrations.';
 $string['no_tp_rejected'] = 'There are no rejected external tool registrations.';
-$string['no_lti_tools'] = 'There are no external tools configured.';
 $string['nocourseexternaltoolsnotice'] = 'There are no LTI External tools yet.';
 $string['noprofileservice'] = 'Profile service not found';
 $string['oauthsecurity'] = 'LTI 1.0/1.1';

ltix/classes/helper.php

@@ -347,7 +347,7 @@ public static function build_request_lti2($tool, $params) {
      * @param string $contentitemsjson The JSON string for the content_items parameter.
      * @return stdClass The array of module information objects.
      * @throws moodle_exception
-     * @throws moodle\mod\lti\OAuthException
+     * @throws \core_ltix\OAuthException
      */
     public static function tool_configuration_from_content_item($typeid, $messagetype, $ltiversion, $consumerkey, $contentitemsjson) {
         $tool = self::get_type($typeid);
@@ -1212,7 +1212,7 @@ public static function get_tag($tagname, $xpath, $attribute = null) {
      * Determines if the given url is for a IMS basic cartridge
      *
      * @param  string $url The url to be checked
-     * @return True if the url is for a cartridge
+     * @return boolean True if the url is for a cartridge
      */
     public static function is_cartridge($url) {
         // If it is empty, it's not a cartridge.
@@ -2289,7 +2289,7 @@ public static function get_launch_data($instance, $nonce = '', $messagetype = 'b
      *
      * @param stdClass $instance the external tool activity settings
      * @param int $foruserid for user param, optional
-     * @return string The HTML code containing the javascript code for the launch
+     * @return void Prints the HTML code containing the javascript code for the launch
      */
     public static function launch_tool($instance, $foruserid=0) {
 
@@ -2497,7 +2497,7 @@ public static function build_request($instance, $typeconfig, $course, $typeid =
      *
      * @param stdClass  $instance       Basic LTI instance object
      * @param string    $orgid          Organisation ID
-     * @param boolean   $ltiversion     LTI version to be used for tool messages
+     * @param string    $ltiversion     LTI version to be used for tool messages
      * @param string    $messagetype    The request message type. Defaults to basic-lti-launch-request if empty.
      *
      * @return array                    Message parameters
@@ -3982,6 +3982,7 @@ public static function get_certs_endpoint() {
      *
      */
     public static function get_token_endpoint() {
+        global $DB;
 
         $response = new \core_ltix\local\ltiservice\response();