Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Missing argument in log message #39

Closed
karacolada opened this issue Jun 13, 2024 · 0 comments · Fixed by #40
Closed

[Bug]: Missing argument in log message #39

karacolada opened this issue Jun 13, 2024 · 0 comments · Fixed by #40
Assignees
@karacolada
Labels
bug Something isn't working

Comments

@karacolada
Copy link
Member

Description

A log message in FAIREvaluatorRequirements (test for FRSM-13-R1-2, line 207) is missing an argument, causing a TypeError . This problem was first noted in pangaea-data-publisher#506.

Expected Behavior

Evaluation should terminate successfully and include a log message indicating that dependency files have been found.

Actual Behavior

TypeError.

Possible Fix

Change message type from log to info.

Steps to reproduce

Run evaluation against https://github.com/paramm-team/pybamm-param.
@karacolada karacolada added the bug Something isn't working label Jun 13, 2024
@karacolada karacolada self-assigned this Jun 13, 2024
@karacolada karacolada mentioned this issue Jun 13, 2024
Closed
karacolada added a commit that referenced this issue Jun 13, 2024
@karacolada
fix [Bug]: Missing argument in log message #39
df50d5d
@karacolada karacolada mentioned this issue Jun 13, 2024
Merged
14 tasks
@karacolada karacolada linked a pull request Jun 13, 2024 that will close this issue
fix [Bug]: Missing argument in log message softwaresaved/fuji#39 #40
Merged
14 tasks
karacolada added a commit that referenced this issue Jun 13, 2024
@karacolada
Merge pull request #40 from softwaresaved/39-bug-missing-argument-in-…
dc7d214 
…log-message

fix [Bug]: Missing argument in log message #39
@karacolada karacolada mentioned this issue Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karacolada karacolada

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix [Bug]: Missing argument in log message softwaresaved/fuji#39 softwaresaved/fuji
1 participant
@karacolada