Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix [Bug]: Missing argument in log message softwaresaved/fuji#39 #40

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

karacolada
Copy link
Member

@karacolada karacolada commented Jun 13, 2024

Description

Amend logging in FAIREvaluatorRequirements.

Related issue: #39

Motivation and context

Bugfix, see #39.

How has this been tested?

Manually tested against a variety of repositories.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@karacolada karacolada linked an issue Jun 13, 2024 that may be closed by this pull request
Copy link

📋 Code Coverage

Code Coverage

Package Line Rate Branch Rate Health
. 61% 35%
config 100% 100%
controllers 86% 56%
evaluators 48% 27%
harvester 58% 48%
helper 65% 55%
models 75% 85%
Summary 63% (7719 / 12179) 55% (3306 / 6028)

Copy link

📋 Pytest Results

19 tests  ±0   19 ✅ ±0   25s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit df50d5d. ± Comparison against base commit 083deb1.

@karacolada karacolada merged commit dc7d214 into master Jun 13, 2024
4 checks passed
@karacolada karacolada mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing argument in log message
1 participant