Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and improve type annotations #47

Merged
merged 9 commits into from
Dec 27, 2024
Merged

Fix and improve type annotations #47

merged 9 commits into from
Dec 27, 2024

Conversation

tom-hg57
Copy link
Collaborator

@tom-hg57 tom-hg57 commented Dec 25, 2024 •
edited
Loading

Type annotations make the code easier to understand. It can also be checked with pyright. (Suggestion: check with pyright in pre-commit workflow.)

  • Add type annotations to cimgen and all lang_pack.py
  • Remove unused functions
  • Fix and improve comments
  • Fix ruff warnings for modernpython
  • Unify use of partials for cpp, rename lang_pack to langPack
  • Rename functions, parameters and variables to fix sonar issues
  • Add function get_base_class to all lang_pack.py (replacing dictionary base and function location)
  • Simplified template file handling for java, javascript and python

@tom-hg57 tom-hg57 marked this pull request as draft December 25, 2024 21:05
@tom-hg57 tom-hg57 force-pushed the fix-and-improve-type-annotations branch from da2c017 to c26b74f Compare December 26, 2024 23:05
@tom-hg57 tom-hg57 marked this pull request as ready for review December 27, 2024 00:27
@tom-hg57 tom-hg57 requested a review from m-mirz December 27, 2024 00:27
@tom-hg57 @m-mirz
Remove unused functions
dd0fb8d 
Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57 @m-mirz
Fix and improve comments, rename function _write_python_files to _wri…
157d3b1 
…te_all_files

Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57 @m-mirz
Add type annotations
2ca2ea5 
Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57 @m-mirz
Fix ruff warnings for modernpython
cfdf185 
Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57 @m-mirz
Unify use of partials for cpp, rename lang_pack to langPack
8b6de0c 
Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57 @m-mirz
Rename functions to fix sonar issues
1d6d38f 
Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57 @m-mirz
Add function get_base_class to all lang_pack.py (replacing dictionary…
245f02d 
… base and function location)

Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57 @m-mirz
Simplified template file handling for java, javascript and python
8e447ab 
Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57 @m-mirz
Rename parameters and variables to fix sonar issues
68c6b84 
Signed-off-by: Thomas Günther <[email protected]>
@m-mirz m-mirz force-pushed the fix-and-improve-type-annotations branch from 26d4a9b to 68c6b84 Compare December 27, 2024 07:38
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@m-mirz m-mirz merged commit 3b44357 into sogno-platform:master Dec 27, 2024
14 checks passed
@tom-hg57 tom-hg57 deleted the fix-and-improve-type-annotations branch December 27, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-mirz m-mirz m-mirz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-hg57 @m-mirz