This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
Fix #7549 #7627
Open
Fix #7549 #7627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #7549,
InitializeMintandInitializeMint2without FreezeAuthority breakdecodeInitializeMintInstructionanddecodeInitializeMint2Instructionrespectively.Since buffer layouts apparently don't support optional fields, this is currently a workaround. Indeed, this solution won't scale well when more than one optional field is present as it would require implementing the same logic for each combination of presence of each optional field.
The actual solution would require supporting optional
Layouts inbuffer-layouts, adapt theStructurelayout to account for it and easily provide a list of spans, then re-implementCOptionPublicKeyLayoutwith it and check indecodeInitializeMintInstructionanddecodeInitializeMint2Instructionif the length of the buffer is in one of the values of spans provided byStructure.Overall, I'd recommend not allowing optional fields, but rather have then set to a null value like 0 or -1.