rpc: optimize getTokenLargestAccounts
#35315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }; | ||
| largest_token_balances.sort_unstable_by(sort_largest); | ||
| let new_entry = (amount, address); | ||
| if token_balances.len() >= NUM_LARGEST_ACCOUNTS { |
There was a problem hiding this comment.
Technically, == should be sufficient here, but I suppose there's no harm in >=
Co-authored-by: Tyera <[email protected]>
|
@CriesofCarrots updated, can you make a final review, please? 🙂 |
|
1.18 backport? 🙂 |
Nope, not for now. Precursor PRs were not backported, plus backports require someone to make a case for them. |
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Feb 27, 2024
* rpc: optimize `getTokenLargestAccounts` * use tuple instead of struct * untuple Co-authored-by: Tyera <[email protected]> --------- Co-authored-by: Tyera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
getTokenLargestAccountscollects all data inVecand after that takes only 30 top accountsSummary of Changes
use
BinaryHeapinstead ofVecand do not keep more than 30 accountsbased on #34583
Fixes #