Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configuration option to disable auditing for object associations #622

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from

Conversation

shepherdmat
Copy link

@shepherdmat shepherdmat commented Apr 24, 2024

Subject

Pull request allows you to globally disable building a database scheme, and attempt to audit object relationships

I am targeting this branch, because it is a new feature.

Closes #601.

Changelog

### Added
- New configuration option `disable_associations` to disable association tracking.

@VincentLanglet
Copy link
Member

Closes #601.

@dmitrach, does it solve your issue ?

(and @axio-vincent since your upvoted the issue)

@phansys phansys added the minor label Aug 20, 2024
@vityachis
Copy link

It works for me, could you merge these changes?

@VincentLanglet
Copy link
Member

It works for me, could you merge these changes?

There is conflict and ci is failing.

@vityachis
Copy link

It works for me, could you merge these changes?

There is conflict and ci is failing.

I suspect the error is due to the use of sprintf.
I can create a new PR if necessary, with this fix and conflict resolution.

@VincentLanglet
Copy link
Member

I can create a new PR if necessary, with this fix and conflict resolution.

Sure

Copy link
Member

@phansys phansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @shepherdmat!

IMO, this PR also requires tests for the audit results.

@vityachis
Copy link

vityachis commented Jan 15, 2025

I can create a new PR if necessary, with this fix and conflict resolution.

Sure

New PR for these changes: #644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore related tables for auditiong
4 participants