-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1012] 간단한 화면에서 MVVM Like 구조 없이 상태관리할 수 있게 구조 변경 #1013
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
e5c7790
[#1012] AuthRepository 가져올 수 있는 EntryPoint 정의, SignOutActivity 간소화
l2hyunwoo 37b038c
[#1012] 패키지네임에 camelCase 제거, SignOutViewModel 제거
l2hyunwoo 07f63f0
[#1012] Rin 추가
l2hyunwoo 4436f86
[#1012] Spotless Apply
l2hyunwoo e180d03
[#1012] AdjustSentence쪽 패키지 이동
l2hyunwoo 91f2095
[#1012] UserRepository EntryPoint 설치
l2hyunwoo d10b4dc
[#1012] 솝탬프 한마디 수정 영역 UiState 정의 및 UI 로직 remember로 따로 빼기
l2hyunwoo dff6d25
[#1012] Context#findActivity util 함수 추가
l2hyunwoo ed0a080
[#1012] Activity에 ModifyProfileState 적용
l2hyunwoo d739db8
[#1012] SideEffect, ViewModel 삭제
l2hyunwoo b39fa8d
[#1012] Spotless Apply
l2hyunwoo 8dcae83
[#1012] Context 직접 참조하는 부분 변경
l2hyunwoo 11b6973
[#1012] mockk 의존성 추가, mypage에 테스트 의존성 추가
l2hyunwoo e3092cc
[#1012] Testable하게 구조 변경 (UserRepository)
l2hyunwoo 073b7f4
[#1012] Add unit test for modify profile state
l2hyunwoo 21e9850
[#1012] Spotless Apply
l2hyunwoo fc18e3c
[#1012] StartArgs -> Argument로 네이밍 변경
l2hyunwoo bd76bee
[#1012] Lint
l2hyunwoo c160ff3
[#1012] MyPage UiState, Action 정의
l2hyunwoo 44762a4
[#1012] MyPage의 UiState Holder 정의
l2hyunwoo 58fda61
[#1012] MyPageActivity에 적용
l2hyunwoo 91f99cf
[#1012] Spotless Apply
l2hyunwoo b984b97
[#1012] generateBaselineProfile
l2hyunwoo e4686ea
[#1012] Spotless Apply
l2hyunwoo 5b16e97
[#1012] generateBaselineProfile
l2hyunwoo 8d2b1f1
[#1012] remove warning
l2hyunwoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
app/src/main/java/org/sopt/official/feature/auth/component/PhoneCertification.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
app/src/main/java/org/sopt/official/feature/auth/feature/autherror/AuthErrorScreen.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
842 changes: 441 additions & 401 deletions
842
app/src/release/generated/baselineProfiles/baseline-prof.txt
Large diffs are not rendered by default.
Oops, something went wrong.
842 changes: 441 additions & 401 deletions
842
app/src/release/generated/baselineProfiles/startup-prof.txt
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
core/analytics/src/main/java/org/sopt/official/analytics/Tracker.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
core/analytics/src/main/java/org/sopt/official/analytics/TrackerModule.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
core/analytics/src/main/java/org/sopt/official/analytics/compose/CompositionLocal.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
core/analytics/src/main/java/org/sopt/official/analytics/compose/LocalTracker.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
core/analytics/src/main/java/org/sopt/official/analytics/impl/AmplitudeTracker.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
core/analytics/src/main/java/org/sopt/official/analytics/impl/FakeTracker.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,7 @@ | |
|
||
plugins { | ||
sopt("feature") | ||
sopt("compose") | ||
} | ||
|
||
android { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
feature/fortune/src/main/java/org/sopt/official/feature/fortune/FortuneActivity.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
feature/fortune/src/main/java/org/sopt/official/feature/fortune/FoundationScreen.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
feature/fortune/src/main/java/org/sopt/official/feature/fortune/component/FortuneTopBar.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
.../main/java/org/sopt/official/feature/fortune/feature/fortuneAmulet/FortuneAmuletScreen.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...c/main/java/org/sopt/official/feature/fortune/feature/fortuneDetail/FortuneDetailRoute.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
feature/fortune/src/main/java/org/sopt/official/feature/fortune/feature/home/HomeScreen.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
feature/mypage/src/main/java/org/sopt/official/feature/mypage/di/EntryPoint.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
/* | ||
* MIT License | ||
* Copyright 2024-2025 SOPT - Shout Our Passion Together | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy | ||
* of this software and associated documentation files (the "Software"), to deal | ||
* in the Software without restriction, including without limitation the rights | ||
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
* copies of the Software, and to permit persons to whom the Software is | ||
* furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included in all | ||
* copies or substantial portions of the Software. | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
* SOFTWARE. | ||
*/ | ||
package org.sopt.official.feature.mypage.di | ||
|
||
import dagger.hilt.EntryPoint | ||
import dagger.hilt.InstallIn | ||
import dagger.hilt.android.EntryPointAccessors | ||
import dagger.hilt.components.SingletonComponent | ||
import org.sopt.official.auth.repository.AuthRepository | ||
import org.sopt.official.common.context.appContext | ||
import org.sopt.official.domain.mypage.repository.UserRepository | ||
import org.sopt.official.domain.soptamp.repository.StampRepository | ||
|
||
@EntryPoint | ||
@InstallIn(SingletonComponent::class) | ||
internal interface AuthEntryPoint { | ||
fun authRepository(): AuthRepository | ||
fun userRepository(): UserRepository | ||
fun stampRepository(): StampRepository | ||
} | ||
|
||
internal val authRepository by lazy { | ||
EntryPointAccessors | ||
.fromApplication(appContext, AuthEntryPoint::class.java) | ||
.authRepository() | ||
} | ||
|
||
internal val userRepository by lazy { | ||
EntryPointAccessors | ||
.fromApplication(appContext, AuthEntryPoint::class.java) | ||
.userRepository() | ||
} | ||
|
||
internal val stampRepository by lazy { | ||
EntryPointAccessors | ||
.fromApplication(appContext, AuthEntryPoint::class.java) | ||
.stampRepository() | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
개인적으로 해당 함수에서
null
이 반환될 경우 그 이유를 JavaDoc으로 적어주시면 좋을 것 같아요! 해당 함수는 이후 기수분들도 많이 사용할 것 같아서요.