[#1011] Google Sign In 설정 #1014
Open
+133
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
l2hyunwoo
changed the base branch from
develop
to
feature/#1011-login-mock-server
leeeyubin
approved these changes
Jan 3, 2025
Comment on lines
76
to
77
| GoogleSignInOptions.Builder(GoogleSignInOptions.DEFAULT_SIGN_IN).requestIdToken("SERVER_CLIENT_ID").requestEmail() | ||
| .build() |
There was a problem hiding this comment.
확인했습니다! 이 부분은 제가 따로 클라이언트 아이디 값 넣어둘게요!
There was a problem hiding this comment.
일단 이거 CredentialManager 사용하는걸로 마이그레이션 해봤어요!! 확인해주셔서 감사해요
Comment on lines
+6
to
+16
| suspend inline fun <R> suspendRunCatching(block: () -> R): Result<R> { | ||
| return try { | ||
| Result.success(block()) | ||
| } catch (t: TimeoutCancellationException) { | ||
| Result.failure(t) | ||
| } catch (c: CancellationException) { | ||
| throw c | ||
| } catch (e: Throwable) { | ||
| Result.failure(e) | ||
| } | ||
| } |
There was a problem hiding this comment.
오호 이 함수를 추가한 이유는 더 상세한 에러를 잡기 위함인가요...?
There was a problem hiding this comment.
정확히는 저 CancellationException은 이 코루틴에서 에러가 발생했을 때 다른 코루틴으로의 예외전파를 시키는 것을 막지 않게 하기 위해서 추가한 코드에요
Reference - Kotlin/kotlinx.coroutines#1814
l2hyunwoo
force-pushed
the
feature/#1011-google-sign-in
branch
from
8126336 to
995e4d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this issue?
Reference