Skip to content

Commit

Permalink
general: Remove redundant usage of cat
Browse files Browse the repository at this point in the history
In general, the substitution ‘$(cat foo)’ may be replaced by the
equivalent but faster ‘$(<foo)’.

See: https://zsh.sourceforge.io/Doc/Release/Expansion.html#Command-Substitution
  • Loading branch information
indrajitr committed May 4, 2023
1 parent 3c002f7 commit 84e0787
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 10 deletions.
2 changes: 1 addition & 1 deletion modules/archive/functions/archive
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
local archive_name path_to_archive _gzip_bin _bzip2_bin _xz_bin _zstd_bin

if (( $# < 2 )); then
cat >&2 <<EOF
>&2 <<EOF
usage: $0 [archive_name.zip] [/path/to/include/into/archive ...]

Where 'archive.zip' uses any of the following extensions:
Expand Down
2 changes: 1 addition & 1 deletion modules/archive/functions/lsarchive
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
local verbose

if (( $# == 0 )); then
cat >&2 <<EOF
>&2 <<EOF
usage: $0 [-option] [file ...]

options:
Expand Down
2 changes: 1 addition & 1 deletion modules/archive/functions/unarchive
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ local extract_dir
local _gzip_bin _bzip2_bin _xz_bin _zstd_bin

if (( $# == 0 )); then
cat >&2 <<EOF
>&2 <<EOF
usage: $0 [-option] [file ...]

options:
Expand Down
2 changes: 1 addition & 1 deletion modules/dpkg/functions/deb-history
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ case "$1" in
zcat $(ls -rt /var/log/dpkg*)
;;
(*)
cat >&2 <<EOF
>&2 <<EOF
Commands:
install - List installed packages
upgrade - List upgraded packages
Expand Down
3 changes: 1 addition & 2 deletions modules/utility/functions/prep
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@

local usage pattern modifiers invert

usage="$(
cat <<EOF
usage="$(<<EOF
usage: $0 [-option ...] [--] pattern [file ...]

options:
Expand Down
3 changes: 1 addition & 2 deletions modules/utility/functions/psub
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@

local usage pattern replacement modifiers

usage="$(
cat <<EOF
usage="$(<<EOF
usage: $0 [-option ...] [--] pattern replacement [file ...]

options:
Expand Down
3 changes: 1 addition & 2 deletions modules/utility/functions/zsh-help
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@

# function zsh-help {

local usage="$(
cat <<EOF
local usage="$(<<EOF
usage: $0 [--help] [--zsh-help-debug] [--all] search term(s)
Options:
--all - search for the term anywhere, not just at the start of a line.
Expand Down

0 comments on commit 84e0787

Please sign in to comment.