Merge pull request #513 from spacelift-io/revert-computed-integration-id

without computed for VCS integration id , too many changed at once
spacelift-io · Feb 7, 2024 · 80c2ffa · 80c2ffa
2 parents eb023b9 + 0240f93
commit 80c2ffa
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 10 deletions.
diff --git a/spacelift/resource_module.go b/spacelift/resource_module.go
@@ -53,7 +53,6 @@ func resourceModule() *schema.Resource {
 							Type:        schema.TypeString,
 							Description: "ID of the Azure Devops integration. If not specified, the default integration will be used.",
 							Optional:    true,
-							Computed:    true,
 							DiffSuppressFunc: func(_, _, new string, res *schema.ResourceData) bool {
 								isDefault := res.Get("azure_devops.0.is_default").(bool)
 
@@ -85,7 +84,6 @@ func resourceModule() *schema.Resource {
 						"id": {
 							Type:        schema.TypeString,
 							Optional:    true,
-							Computed:    true,
 							Description: "The ID of the Bitbucket Cloud integration. If not specified, the default integration will be used.",
 							DiffSuppressFunc: func(_, _, new string, res *schema.ResourceData) bool {
 								isDefault := res.Get("bitbucket_cloud.0.is_default").(bool)
@@ -118,7 +116,6 @@ func resourceModule() *schema.Resource {
 						"id": {
 							Type:        schema.TypeString,
 							Optional:    true,
-							Computed:    true,
 							Description: "The ID of the Bitbucket Datacenter integration. If not specified, the default integration will be used.",
 							DiffSuppressFunc: func(_, _, new string, res *schema.ResourceData) bool {
 								isDefault := res.Get("bitbucket_datacenter.0.is_default").(bool)
@@ -173,7 +170,6 @@ func resourceModule() *schema.Resource {
 						"id": {
 							Type:        schema.TypeString,
 							Optional:    true,
-							Computed:    true,
 							Description: "The ID of the GitHub Enterprise integration. If not specified, the default integration will be used.",
 							DiffSuppressFunc: func(_, _, new string, res *schema.ResourceData) bool {
 								isDefault := res.Get("github_enterprise.0.is_default").(bool)
@@ -201,7 +197,6 @@ func resourceModule() *schema.Resource {
 							Type:        schema.TypeString,
 							Description: "ID of the Gitlab integration. If not specified, the default integration will be used.",
 							Optional:    true,
-							Computed:    true,
 							DiffSuppressFunc: func(_, _, new string, res *schema.ResourceData) bool {
 								isDefault := res.Get("gitlab.0.is_default").(bool)
 

diff --git a/spacelift/resource_stack.go b/spacelift/resource_stack.go
@@ -140,7 +140,6 @@ func resourceStack() *schema.Resource {
 						"id": {
 							Type:        schema.TypeString,
 							Optional:    true,
-							Computed:    true,
 							Description: "The ID of the Azure Devops integration. If not specified, the default integration will be used.",
 							DiffSuppressFunc: func(_, _, new string, res *schema.ResourceData) bool {
 								isDefault := res.Get("azure_devops.0.is_default").(bool)
@@ -224,7 +223,6 @@ func resourceStack() *schema.Resource {
 						"id": {
 							Type:        schema.TypeString,
 							Optional:    true,
-							Computed:    true,
 							Description: "The ID of the Bitbucket Cloud integration. If not specified, the default integration will be used.",
 							DiffSuppressFunc: func(_, _, new string, res *schema.ResourceData) bool {
 								isDefault := res.Get("bitbucket_cloud.0.is_default").(bool)
@@ -257,7 +255,6 @@ func resourceStack() *schema.Resource {
 						"id": {
 							Type:        schema.TypeString,
 							Optional:    true,
-							Computed:    true,
 							Description: "The ID of the Bitbucket Datacenter integration. If not specified, the default integration will be used.",
 							DiffSuppressFunc: func(_, _, new string, res *schema.ResourceData) bool {
 								isDefault := res.Get("bitbucket_datacenter.0.is_default").(bool)
@@ -348,7 +345,6 @@ func resourceStack() *schema.Resource {
 						"id": {
 							Type:        schema.TypeString,
 							Optional:    true,
-							Computed:    true,
 							Description: "The ID of the GitHub Enterprise integration. If not specified, the default integration will be used.",
 							DiffSuppressFunc: func(_, _, new string, res *schema.ResourceData) bool {
 								isDefault := res.Get("github_enterprise.0.is_default").(bool)
@@ -375,7 +371,6 @@ func resourceStack() *schema.Resource {
 						"id": {
 							Type:        schema.TypeString,
 							Optional:    true,
-							Computed:    true,
 							Description: "The ID of the Gitlab integration. If not specified, the default integration will be used.",
 							DiffSuppressFunc: func(_, _, new string, res *schema.ResourceData) bool {
 								isDefault := res.Get("gitlab.0.is_default").(bool)